Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

replace patch with update api to rewrite IPPool #114

Closed
wants to merge 5 commits into from
Closed

replace patch with update api to rewrite IPPool #114

wants to merge 5 commits into from

Conversation

pperiyasamy
Copy link

as we noticied patch operation doesn't provide concurrency safety (refer this link), replace it with update api to make ip assignment to be atomic.

TODO: large scale verification is still pending

@pperiyasamy pperiyasamy mentioned this pull request Jun 29, 2021
Closed
@dougbtv dougbtv mentioned this pull request Jun 29, 2021
Open
@pperiyasamy
replace patch with update api to rewrite IPPool
64a6d68 
It is found that patch api doesn't guarantee concurrent writes on the K8s objects, so replace it with update api so that latest ip pool is read again upon status conflict error and won't lead to duplicate ip assignment across the pods.

Signed-off-by: Periyasamy Palanisamy <[email protected]>
@pperiyasamy
return last available newip, err when context timeouts
eeee9fc 
Signed-off-by: Periyasamy Palanisamy <[email protected]>
@pperiyasamy
make request timeout configurable
38d9cea 
Signed-off-by: Periyasamy Palanisamy <[email protected]>
@pperiyasamy
return context timeout error for deallocate
7ca896c 
Signed-off-by: Periyasamy Palanisamy <[email protected]>
@coveralls
Copy link

Pull Request Test Coverage Report for Build 1014920180

  • -36 of 49 (26.53%) changed or added relevant lines in 4 files are covered.
  • 3 unchanged lines in 1 file lost coverage.
  • Overall coverage increased (+1.04%) to 38.121%
Changes Missing Coverage Covered Lines Changed/Added Lines %
pkg/storage/kubernetes.go 0 3 0.0%
cmd/whereabouts.go 0 4 0.0%
pkg/storage/storage.go 0 29 0.0%
Files with Coverage Reduction New Missed Lines %
pkg/storage/storage.go 3 0%
Totals Coverage Status
Change from base Build 986532013: 1.04%
Covered Lines: 353
Relevant Lines: 926
💛 - Coveralls

@coveralls
Copy link

Pull Request Test Coverage Report for Build 1014920180

  • 13 of 49 (26.53%) changed or added relevant lines in 4 files are covered.
  • 3 unchanged lines in 1 file lost coverage.
  • Overall coverage increased (+1.04%) to 38.121%
Changes Missing Coverage Covered Lines Changed/Added Lines %
pkg/storage/kubernetes.go 0 3 0.0%
cmd/whereabouts.go 0 4 0.0%
pkg/storage/storage.go 0 29 0.0%
Files with Coverage Reduction New Missed Lines %
pkg/storage/storage.go 3 0%
Totals Coverage Status
Change from base Build 986532013: 1.04%
Covered Lines: 353
Relevant Lines: 926
💛 - Coveralls

@dougbtv
Copy link
Member

dougbtv commented Jun 23, 2022

thanks for the contribution and your contribution to the final outcome for the write-locking issues we had.

@dougbtv dougbtv closed this Jun 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pperiyasamy @coveralls @dougbtv